[wp-trac] [WordPress Trac] #39221: Customize: Prevent setting previewing logic when settings will be saved

WordPress Trac noreply at wordpress.org
Fri May 19 09:13:38 UTC 2017


#39221: Customize: Prevent setting previewing logic when settings will be saved
--------------------------+--------------------
 Reporter:  westonruter   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.8.1
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------

Comment (by stubgo):

 @westonruter Sounds like adding an additional argument is reasonable.
 Maybe it would also make sense to create a method
 `WP_Customize_Manager::maybe_preview_settings()` (or something similar)
 and instead of making a check separately in `WP_Customize_Nav_Menus` and
 `WP_Customize_Widgets` etc. just call
 `$this->manager->maybe_preview_settings( $settings )`?

 Couldn't think of a better alternative to adding an additional argument to
 `WP_Customize_Manager` for skipping the preview.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39221#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list