[wp-trac] [WordPress Trac] #40702: Add WordCamps and meetup events to the News Dashboard widget

WordPress Trac noreply at wordpress.org
Thu May 18 23:27:17 UTC 2017


#40702: Add WordCamps and meetup events to the News Dashboard widget
----------------------------+-----------------------------------
 Reporter:  iandunn         |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  4.8
Component:  Administration  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript, rest-api
----------------------------+-----------------------------------

Comment (by iandunn):

 [attachment:40702-geoip.4.diff] combines [attachment:40702-geoip.3.diff]
 with [attachment:40702-request-args.diff] from @coreymckrill. The former
 can take advantage of the fact that the latter makes `$request_args`
 available, and using that variable makes a couple places in the code more
 intuitive and readable, as opposed to getting the same values from less
 obvious sources.

 See comment:63 and comment:64 for the details on those patches.

 This patch also 2 bugs in [attachment:40702-geoip.3.diff]:
 1. An edge case where a `WP_Error` object was treated as an array.
 1. An edge case where an IP value of `false` would be saved to the
 database, and could never be overwritten with a valid IP.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40702#comment:65>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list