[wp-trac] [WordPress Trac] #40724: Strict get_blog_count() unit test fails on some setups

WordPress Trac noreply at wordpress.org
Thu May 11 15:44:09 UTC 2017


#40724: Strict get_blog_count() unit test fails on some setups
--------------------------------+------------------------
 Reporter:  flixos90            |       Owner:  flixos90
     Type:  defect (bug)        |      Status:  reopened
 Priority:  normal              |   Milestone:  4.8
Component:  Networks and Sites  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch close     |     Focuses:  multisite
--------------------------------+------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch => has-patch close


Comment:

 Replying to [comment:4 flixos90]:
 >
 > I thought this wasn't something to consider because of BC, but if it's
 not, let's go for it!

 `get_blog_count()` has always returned a numeric string when I've tested.
 We're probably okay to cast this to integer so that it matches the
 docs/expectations, but that seems like a good change in trunk right after
 4.8 rather than before.

 I'd be okay to leave this ticket as is for now with the test fixed and
 address the rest later in a new ticket.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40724#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list