[wp-trac] [WordPress Trac] #35958: Failing dbDelta tests due to MySQL error

[WordPress Trac]

#35958: Failing dbDelta tests due to MySQL error
--------------------------+------------------
 Reporter:  johnbillion   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.8
Component:  Database      |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------

Comment (by jeremyfelt):

 [attachment:35958.diff] applies the maximum index length to the key
 definitions rather than the field definitions, which matches the approach
 taken in [31349] when core was adjusted to better support utf8mb4. VARCHAR
 will support larger fields, the indexes have the max size.

 Many of these are not entirely necessary, as the tests are using
 `dbDelta()` to determine that nothing changed and don't actually end up
 issuing MySQL commands. But, for consistency, I updated all of the key
 definitions that would require the max length to be set.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35958#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform