[wp-trac] [WordPress Trac] #39186: Bulk actions not correctly applied when selecting bulk actions in both the top and bottom bulk actions dropdowns

WordPress Trac noreply at wordpress.org
Tue Mar 21 17:42:43 UTC 2017


#39186: Bulk actions not correctly applied when selecting bulk actions in both the
top and bottom bulk actions dropdowns
----------------------------------------+-----------------------------
 Reporter:  engelen                     |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  4.8
Component:  Quick/Bulk Edit             |     Version:  4.7
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  administration
----------------------------------------+-----------------------------

Comment (by desrosj):

 I found this ticket when working on #40113 which is related to changing
 roles for users in the edit site section of the network admin. Like
 @engelen detailed above with term bulk edit and user roles, this area
 could have potentially large negative consequences.

 On the edit site users dialogue in the network admin, the logic in the
 patch on #40113 (which was copied over from the single site user edit
 screen) will always respect the second dropdown field.

 Say a person is at the bottom of the page and selects a role. Then they
 scroll up selecting users, and then select a different role in the
 dropdown at the top. The bottom dropdown value would be applied to all
 selected users. This could be very bad, and a huge pain if a large number
 of users had been selected. Especially if the user selects Administrator
 in the bottom dropdown, and then changes their mind at the top to a lesser
 role. All users would be promoted to Administrators.

 To reproduce, select a role in the dropdown at the top of the table, and
 then select a different role in the bottom dropdown. Click change in
 either row, and the second dropdown is the value respected.

 I think for certain core fields (like role change, bulk edit), it would
 make sense to make these values always match.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39186#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list