[wp-trac] [WordPress Trac] #40047: Add term_meta to WP_Term class getter method

WordPress Trac noreply at wordpress.org
Mon Mar 13 14:22:21 UTC 2017


#40047: Add term_meta to WP_Term class getter method
-----------------------------------+------------------------------
 Reporter:  barryceelen            |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Taxonomy               |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------------

Comment (by boonebgorges):

 >  So I don't think the BC concerns are very critical here, especially
 since core rarely introduces new properties (since we never change the
 database schema).

 Perhaps not, but there's some precedent for adding properties that are not
 part of the schema. See eg `$post->ancestors`.

 I'm not against having a helper method for fetching meta - `get_meta()`
 would be fine, or even using meta as the fallback in a general `get()`
 method. It's just the `__get()` implementation that feel inappropriate to
 me.

 In any case, I agree that we need a general agreement about this across
 our object classes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40047#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list