[wp-trac] [WordPress Trac] #35958: Failing dbDelta tests due to MySQL error

[WordPress Trac]

#35958: Failing dbDelta tests due to MySQL error
--------------------------+--------------------
 Reporter:  johnbillion   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.7.4
Component:  Database      |     Version:  4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------
Changes (by jeremyfelt):

 * keywords:  has-patch dev-feedback => has-patch
 * version:   => 4.2
 * milestone:  Future Release => 4.7.4


Comment:

 This will likely be even more visible when VVV 2.0 ships, as MariaDB 10.1
 is default.

 We changed the default core `varchar` keys to `varchar(191)` in [31349] so
 that utf8mb4 could be supported. I think it makes sense to change any keys
 created in the `dbDelta` tests as well. It's probably not core's
 responsibility to check whether a DB can support any more than that.

 [attachment:35958-varchar-191-object-property.diff] seems to make the most
 sense at first glance, though I wouldn't be opposed to
 [attachment:35958-varchar-191-string-literal.diff] either.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35958#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform