[wp-trac] [WordPress Trac] #30155: Fix crop image functionality within edit flow

[WordPress Trac]

#30155: Fix crop image functionality within edit flow
-------------------------------------+-------------------------------------
 Reporter:  sonjanyc                 |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Media                    |     Version:  2.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch reporter-      |     Focuses:  ui, accessibility,
  feedback needs-testing             |  javascript
-------------------------------------+-------------------------------------
Changes (by adamsilverstein):

 * keywords:   => has-patch reporter-feedback needs-testing


Comment:

 [attachment:30155.2.diff] is an alternate version that more closely
 matches the description of steps 1-3 from @sonjanyc -
 * The crop button is always 'enabled'
 * Clicking the crop button with no selection selects the entire image
 * Clicking the crop button with the entire image selected doesn't do
 anything
 * Clicking the crop button with a selection crops as expected

 Here is a screencast:

 [[Image(https://cl.ly/451l2H1E0W24/Screen%20Recording%202017-06-23%20at%2008.48%20AM.gif)]]

 Appreciate testing/review/feedback. Shall we get this in and then continue
 to work on the image ratio buttons?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30155#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform