[wp-trac] [WordPress Trac] #41124: TinyMCE popup doesn't works with latest release

[WordPress Trac]

#41124: TinyMCE popup doesn't works with latest release
--------------------------+-----------------------------
 Reporter:  UmeshSingla   |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  TinyMCE       |    Version:  4.8
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 I'm using TinyMCE popup for a custom plugin, with latest WordPress 4.8, it
 throws a error.
 [[Image(https://monosnap.com/file/3vlSZSNz47BObS8KfSKKvaTOzYH3Yw.png)]]

 I dig in deeper, and found out, the changes in
 https://core.trac.wordpress.org/changeset/40583
 https://build.trac.wordpress.org/changeset/40453/, are causing the issue.

 https://build.trac.wordpress.org/browser/trunk/wp-
 includes/js/tinymce/tiny_mce_popup.js#L56
 https://build.trac.wordpress.org/browser/trunk/wp-
 includes/js/tinymce/utils/mctabs.js#L15

 `dom` and `util` are loaded directly and not as plugins, and hence when
 `createInstance` is called in
 https://build.trac.wordpress.org/browser/trunk/wp-
 includes/js/tinymce/plugins/compat3x/plugin.js#L284, tinymce is unable to
 resolve the Classnames and it throws the above error.

 The fix is to revert the path to `tinymce.util.Dispatcher` and
 `tinymce.dom.DOMUtils`

 I couldn't locate the use of these at other places in core, so not sure,
 if that's gonna break something else. But I did test the regular text
 editor in WordPress and TinyMCE Advance plugin, they both worked fine with
 the changes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41124>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform