[wp-trac] [WordPress Trac] #41057: Update PHP codebase per WordPress PHP Coding Standards

WordPress Trac noreply at wordpress.org
Sat Jun 17 00:23:17 UTC 2017


#41057: Update PHP codebase per WordPress PHP Coding Standards
----------------------------+-----------------------
 Reporter:  netweb          |       Owner:  pento
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  4.9
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+-----------------------

Comment (by jrf):

 All:

 FYI: I've made a small start with a visual inspection of the fixes and -
 while the majority of the fixes is good -, I've already found a number of
 additional issues other than the one previously reported.

 I will open issues for each of these in the GH repos of WPCS and - where
 relevant - upstream in PHPCS.

 Regarding the fixes needed for PHPCS native sniffs, the timing is not
 ideal.
 WPCS is currently only compatible with PHPCS 2.x, but as PHPCS 3.x has
 been released last month, it may well be that fixes will no longer be
 accepted for the PHPCS 2.x branch.
 I'll open a discussion about this in the PHPCS repo and will refer to this
 issue as the reason why we'd like to see the fixes be accepted into the
 PHPCS 2.x branch.

 I've created a branch in my GH fork of WP to keep track of the fixes I
 deem correct/(partially) faulty which can be found here:
 https://github.com/jrfnl/develop.wordpress/commits/test/WPCS-autofixing

 It would be great if more people could spend some time on visual
 inspections & reporting any bugs found, as that would allow me to spend
 time fixing things instead.

 New issues opened so far:
 https://github.com/WordPress-Coding-Standards/WordPress-Coding-
 Standards/issues/970
 https://github.com/WordPress-Coding-Standards/WordPress-Coding-
 Standards/issues/971

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41057#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list