[wp-trac] [WordPress Trac] #40975: 'Empty Spam' and 'Empty Trash' comment buttons not displayed on mobile

WordPress Trac noreply at wordpress.org
Fri Jun 9 12:57:05 UTC 2017


#40975: 'Empty Spam' and 'Empty Trash' comment buttons not displayed on mobile
----------------------------+-------------------
 Reporter:  SergeyBiryukov  |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  4.8.1
Component:  Comments        |    Version:  4.8
 Severity:  normal          |   Keywords:
  Focuses:  administration  |
----------------------------+-------------------
 Since [26134], top navigation for list tables is not displayed on mobile,
 which means that 'Empty Spam' and 'Empty Trash' buttons were only
 displayed in bottom navigation.

 Since [40297], these buttons are not displayed in bottom navigation either
 (on both mobile and desktop) if there's only one page of comments in
 Spam/Trash, because `$this->extra_items` is empty, `$this->items`
 [source:tags/4.8/src/wp-admin/includes/class-wp-comments-list-
 table.php?marks=458#L445 ends up empty too] in `::display()`, so
 `$this->has_items()` returns false.

 The lack of the button also causes the `%s items` string to overlap with
 the search bar, see the screenshot.

 If there are two or more pages of comments in Spam/Trash, the buttons are
 displayed as expected.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40975>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list