[wp-trac] [WordPress Trac] #40338: Twenty Seventeen: Layout broken and JS error in `wp-activate.php`

[WordPress Trac]

#40338: Twenty Seventeen: Layout broken and JS error in `wp-activate.php`
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Bundled Theme                        |  Review
 Severity:  normal                               |     Version:  4.7
 Keywords:  has-screenshots has-patch needs-     |  Resolution:
  testing                                        |     Focuses:  multisite
-------------------------------------------------+-------------------------
Changes (by xkon):

 * keywords:  needs-patch has-screenshots => has-screenshots has-patch
     needs-testing


Comment:

 Hello, '''40338.diff''' should solve all the issues.

 I added 2 custom css styles for the body when you are viewing the `wp-
 activate.php` and `wp-signup.php` width `wp-activate-page` and `wp-signup-
 page` to address the js issue. It was caused because there is no sidebar
 rendered on these pages and the script was still trying to set the offsets
 for it with `sidebarPosBottom = sidebarPos.top + ( $sidebar.height() + 28
 );` in global.js .

 TwentyFourteen is a minor css fix.

 All these where tested under a Multisite install so be kind if somebody
 can to make a test on a single as well to be safe in case of extra errors.

 Best regards,
 Konstantinos

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40338#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform