[wp-trac] [WordPress Trac] #41339: WP_Comments_Query::__construct() should allow a 'status__not_in' parameter

WordPress Trac noreply at wordpress.org
Sat Jul 15 19:58:55 UTC 2017


#41339: WP_Comments_Query::__construct() should allow a 'status__not_in' parameter
-------------------------+------------------------------
 Reporter:  pbiron       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Comments     |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------
Changes (by pbiron):

 * keywords:   => has-patch


Comment:

 I went back-and-forth over whether the `$status__not_in` parameter should
 accept a space/comma separated list like `$status` does.

 I decided to not allow that because it seems that is a "legacy" construct
 and `$xxx__not_in` parameters added more recently (in this class and
 others) only accept true arrays.

 I'm certainly open to suggestions that it should allow a space/comma
 separated list.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41339#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list