[wp-trac] [WordPress Trac] #38181: Add oEmbed support for Amazon Kindle Instant Previews

WordPress Trac noreply at wordpress.org
Fri Jul 14 10:51:49 UTC 2017


#38181: Add oEmbed support for Amazon Kindle Instant Previews
-------------------------------------------------+-------------------------
 Reporter:  jsepia                               |       Owner:  swissspidy
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9
Component:  Embeds                               |     Version:  4.7
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by johnbillion):

 * milestone:  Future Release => 4.9


Comment:

 This generally looks good.

 A few points:

 * `amzn.onl` doesn't appear to exist or resolve.
 * The `canonical TLD:` comments in
 `test_amazon_kindle_preview_non_us_embed()` have gotten a bit muddled.
 They don't match the assertions. The tests pass, though.

 I'd love to get complete test coverage for all our oEmbed providers, but
 network problems cause too many false failures. See #32360.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38181#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list