[wp-trac] [WordPress Trac] #40503: Use get_network_option in wpmu_create_blog

WordPress Trac noreply at wordpress.org
Thu Jul 6 06:05:03 UTC 2017


#40503: Use get_network_option in wpmu_create_blog
--------------------------------------+------------------------
 Reporter:  spacedmonkey              |       Owner:  flixos90
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.9
Component:  Networks and Sites        |     Version:  3.0
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+------------------------

Comment (by DrewAPicture):

 Replying to [comment:8 flixos90]:
 > @DrewAPicture I take that as a confirmation that changing variable names
 like that to follow current naming conventions is acceptable. :)

 I don't have a problem with it, as long as it's improving the ability for
 the code to better self-dccument. The `$site_id` vs `$network_id` thing is
 super confusing in a bunch of places – it would be good to provide some
 clarity here and elsewhere.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40503#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list