[wp-trac] [WordPress Trac] #40503: Use get_network_option in wpmu_create_blog

[WordPress Trac]

#40503: Use get_network_option in wpmu_create_blog
----------------------------------------+------------------------
 Reporter:  spacedmonkey                |       Owner:  flixos90
     Type:  enhancement                 |      Status:  reviewing
 Priority:  normal                      |   Milestone:  4.9
Component:  Networks and Sites          |     Version:  3.0
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  multisite
----------------------------------------+------------------------
Changes (by flixos90):

 * keywords:  early has-patch => has-patch needs-unit-tests
 * status:  assigned => reviewing


Comment:

 The actual change in the patch looks good.

 Changing the variable name from `$site_id` to `$network_id` is not really
 a practice we've been following, but recent efforts in ensuring
 consistency with our coding standards give me a feeling that this becomes
 more acceptable. I'm not entirely sure the name change belongs in here,
 but I'm not opposed either.

 A unit test will be necessary though.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40503#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform