[wp-trac] [WordPress Trac] #37616: Replace `is_super_admin()` calls with real capability checks

[WordPress Trac]

#37616: Replace `is_super_admin()` calls with real capability checks
-----------------------------+------------------------
 Reporter:  flixos90         |       Owner:
     Type:  task (blessed)   |      Status:  reviewing
 Priority:  normal           |   Milestone:  4.8
Component:  Role/Capability  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:  multisite
-----------------------------+------------------------

Comment (by flixos90):

 In [changeset:"39932"]:
 {{{
 #!CommitTicketReference repository="" revision="39932"
 Multisite: Do not check for `is_super_admin()` when trying to set user
 settings.

 The checks were introduced in [22256] to prevent user settings to be set
 for super admins that were not a member of the current site. However the
 latter should apply to any kind of user, so the `is_super_admin()` check
 is redundant. Furthermore, removing these checks is necessary for the
 ongoing effort to get rid of `is_super_admin()` checks in general.

 Props chandrapatel for initial patch.
 Fixes #39199. See #37616.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37616#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform