[wp-trac] [WordPress Trac] #16773: Unescaped preg_match breaks with PHP 5.3 Namespaced Widget Classes.

WordPress Trac noreply at wordpress.org
Sun Jan 15 06:02:03 UTC 2017


#16773: Unescaped preg_match breaks with PHP 5.3 Namespaced Widget Classes.
-------------------------------------------------+-------------------------
 Reporter:  5ubliminal                           |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Widgets                              |  Review
 Severity:  minor                                |     Version:  3.1
 Keywords:  has-patch needs-unit-tests needs-    |  Resolution:
  testing                                        |     Focuses:
-------------------------------------------------+-------------------------

Comment (by westonruter):

 @SergeyBiryukov good point. Another consideration is perhaps it not a good
 idea to use the `sanitize_key` function at all because the return value is
 filtered so in reality we have no idea what it could actually return. As
 such, maybe it is better to copy the logic from `sanitize_key` to inline
 it?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16773#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list