[wp-trac] [WordPress Trac] #37887: Make attachments atomic until a Customizer session is published

WordPress Trac noreply at wordpress.org
Sat Jan 14 03:09:45 UTC 2017


#37887: Make attachments atomic until a Customizer session is published
-------------------------+-----------------------------
 Reporter:  fjarrett     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Customize    |     Version:  4.7
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:  administration
-------------------------+-----------------------------

Comment (by azaozz):

 Replying to [comment:10 westonruter]:
 > My position is that anything done during customization w/ live preview
 should be non-destructive (non-mutating) until the user explicitly wants
 the changes to go live. This needn't be restricted to the customize
 preview. In the future if we allow entering into a customization session
 from the frontend (i.e. frontend editing) the same principle should apply.
 Everything done to the site should be “staged” in a draft (changeset) that
 goes live once the user is happy with the changes.

 Yeah, that makes sense for the way the customizer currently works: provide
 UI for changing the settings that can be previewed, and show a preview (in
 another area on the screen).

 However this workflow is no good in some more complex cases. For example:
 writing and editing posts in the customizer iframe. There you have a
 "draft" state that is independent of other settings or "components" of the
 same post, like media that is embedded in it. So what would happen to
 images, audio, video uploaded to the draft post?

 > A missing piece in the current customizer implementation is that there
 is no UI for saving a draft of changes: the `customize_changeset` posts
 created during customizer sessions are always created with the `auto-
 draft` status (as well as the posts created for any page/post stubs).
 Allowing changesets to be longer-lived drafts is what #31089 and the
 [https://github.com/xwp/wp-customize-snapshots Customize Snapshots]
 feature plugin are addressing.

 Same as above. If that gets implemented, and the user saves a "draft of
 changes", what will happen to images uploaded while in the customizer, and
 images selected for some purpose while in the customizer, and why these
 cases should be different?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37887#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list