[wp-trac] [WordPress Trac] #35958: Failing dbDelta tests due to MySQL error

[WordPress Trac]

#35958: Failing dbDelta tests due to MySQL error
------------------------------------+-----------------------------
 Reporter:  johnbillion             |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Database                |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------------

Comment (by caseypatrickdriscoll):

 I can confirm this on a new VVV instance with MariaDB 5.5. A similar
 thread is here https://core.trac.wordpress.org/ticket/35249

 Since WP 4.6, all tables are set with `utf8mb4` charset and collation if
 it is available.

 https://core.trac.wordpress.org/browser/tags/4.6/src/wp-includes/wp-
 db.php#L758

 The magic number should be `191` as that is the amount of four-byte
 characters available under the 767 `ENGINE=MyISAM` limit `(191 * 4 = 764
 bytes)`

 As string literal:
 https://dl.dropboxusercontent.com/s/x30kpsxv5nzyoko/2017-02-24%20at%2018.10.png

 As object property:
 https://dl.dropboxusercontent.com/s/2apntbcurpwwn74/2017-02-24%20at%2018.16.png

 Attached are two patches, one with the `191` string literal in every
 location, the other with it set as an Object Property. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35958#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform