[wp-trac] [WordPress Trac] #37181: Use metadata api in *_network_options

[WordPress Trac]

#37181: Use metadata api in *_network_options
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.0
Component:  Networks and Sites                   |     Version:  4.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch ms-roadmap dev-feedback    |     Focuses:  multisite
  has-unit-tests                                 |
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 Replying to [comment:41 jeremyfelt]:
 >
 >
 > * We're switching from `site-options` to `site_meta` as the cache group,
 but still using `site-options` for a handful of other
 things—`current_network`, `networks_have_paths`, etc... This is probably
 okay because we weren't ever storing those "options" in the DB.
 I think we need to support the `site-options` cache group forever more. It
 is ued else where in core and I am personally use it for some plugin. I
 see more harm in leaving it.
 > * We'll want to make sure once this is in that external object cache
 drop-ins are aware/updated with the new global cache group.
 Most modern object cache drops implement the `wp_cache_add_global_groups`,
 which should do this for us. Examples, can found,
 [https://github.com/humanmade/memcache-object-cache/blob/master/object-
 cache.php#L128 here], [https://github.com/Automattic/wp-
 memcached/blob/master/object-cache.php#L101 here],
 [https://github.com/tollmanz/wordpress-pecl-memcached-object-
 cache/blob/master/object-cache.php#L744 here],
 [https://github.com/stuttter/wp-spider-cache/blob/master/wp-spider-
 cache/includes/functions.php#L827 here] and [https://github.com/pantheon-
 systems/wp-redis/blob/master/object-cache.php#L212 here]. These are the
 largest plugins that I know of. Older ones may not have it implement it,
 but that will break other things and is not a core problem.
 > * In general, I think our network option tests could use some work. For
 something like this we should write some more tests that rely on an
 external object cache.
 Any ideas of this @jeremyfelt ?
 > * Is it possible that anyone is relying on `notoptions` right now for
 some reason? May need to do some digging through plugins briefly to see if
 anything stands out.
 A quick look of github, shows all the refrences to it, are people checking
 core into GH. I havent found a plugin in the wild that uses

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37181#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform