[wp-trac] [WordPress Trac] #42766: Issue in update password From admin side and login ith same password

[WordPress Trac]

#42766: Issue in update password From admin side and login ith same password
-------------------------------------+-------------------------------------
 Reporter:  ronakganatra             |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Administration           |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  ui, javascript,
  patch needs-unit-tests             |  administration, performance
-------------------------------------+-------------------------------------
Changes (by adamsilverstein):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch needs-
     unit-tests


Comment:

 @1naveengiri Thanks for the patch! this looks like it will resolve the
 issue, I will give it a test.

 Did you consider checking for empty vs. trimming? i guess trimming is
 better, spaces at the beginning or end of passwords are likely copy/paste
 or user entry errors.

 I'm not sure we need the error message,  would users get that when
 submitting a blank password field? they might expect empty to indicate no
 change (and not an error).

 Additionally, it would be good to add a unit test here validating that a
 blank password will not be saved.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42766#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform