[wp-trac] [WordPress Trac] #42771: WP_Term::get_instance() regression for non-category terms queried with 'category' taxonomy

[WordPress Trac]

#42771: WP_Term::get_instance() regression for non-category terms queried with
'category' taxonomy
--------------------------+---------------------
 Reporter:  markjaquith   |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  high          |   Milestone:  4.9.2
Component:  Taxonomy      |     Version:  4.9
 Severity:  major         |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------
Changes (by boonebgorges):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 The following functions have been made taxonomy-agnostic:

 * `get_category_link()` #42717
 * `get_tag_link()`
 * `get_the_category_by_ID()`
 * `category_description()` #42605

 I've done a review of other category functions, and I don't see any more
 obvious candidates for the same treatment.

 It's worth noting that there's still the possibility for regressions in
 cases where people are passing a mismatched ID + taxonomy into *any* term
 function, since previously these queries would sometimes have worked,
 while now they won't. This seems like less of an important regression,
 since these sorts of usages are clearly a result of user error (or some
 sort of shared-term legacy problem).

 So, I'm going to close this ticket, but let's reopen if we come across
 more similar regressions in the wild.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42771#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform