[wp-trac] [WordPress Trac] #39660: Missing singular placeholder, needed for some languages on comments.php

WordPress Trac noreply at wordpress.org
Tue Aug 29 11:36:44 UTC 2017


#39660: Missing singular placeholder, needed for some languages on comments.php
---------------------------+-----------------------------
 Reporter:  bplv           |       Owner:  SergeyBiryukov
     Type:  enhancement    |      Status:  reviewing
 Priority:  normal         |   Milestone:  4.9
Component:  Bundled Theme  |     Version:  4.7.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:2 SergeyBiryukov]:
 > This is fixed in
 [https://themes.trac.wordpress.org/browser/twentysixteen/1.3/comments.php?marks=36,37#L28
 Twenty Sixteen] and
 [https://core.trac.wordpress.org/browser/tags/4.7.1/src/wp-
 content/themes/twentyseventeen/comments.php?marks=41,42#L34 Twenty
 Seventeen]

 Just noticed `get_comments_number()` returns a string, and Twenty Sixteen
 compares it to an integer, which doesn't work as expected. Twenty
 Seventeen does it correctly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39660#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list