[wp-trac] [WordPress Trac] #37923: Introduce shared wp_blogmeta database table for multisite installation

WordPress Trac noreply at wordpress.org
Mon Aug 21 18:26:35 UTC 2017


#37923: Introduce shared wp_blogmeta database table for multisite installation
-------------------------------------------------+-------------------------
 Reporter:  johnjamesjacoby                      |       Owner:
     Type:  feature request                      |  spacedmonkey
 Priority:  normal                               |      Status:  assigned
Component:  Networks and Sites                   |   Milestone:  4.9
 Severity:  normal                               |     Version:
 Keywords:  has-patch has-unit-tests needs-      |  Resolution:
  testing ms-roadmap                             |     Focuses:  multisite
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 In there
 [https://core.trac.wordpress.org/attachment/ticket/37923/37923.5.diff
 37923.5.diff] there are a number of key changes.

 - There is now a check to see if the table exists before write flag to
 database.
 - Default network options now populate value of `site_meta_supported`
 - Use `get_network_option`, even through I think it looks a little ugly.
 - I have kept the change of `sanitize_key` in load.php. I think it is has
 deeper effects of moving the formatting.php file might be larger than we
 thought. It is 6k of code, loading it early might have performance
 effects.
 - Do check for network option in `delete_site_meta_by_key` and
 `update_sitemeta_cache`

 I agree with @boonebgorges that, where I do not like the return false
 pattern, it is what was decided and should either be changed everywhere
 and kept the same.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37923#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list