[wp-trac] [WordPress Trac] #38268: WP_Comment_Query Pagination

[WordPress Trac]

#38268: WP_Comment_Query Pagination
--------------------------------------+------------------------
 Reporter:  wordpresssites            |       Owner:  AdamWills
     Type:  enhancement               |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.9
Component:  Comments                  |     Version:  4.7
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------------
Changes (by boonebgorges):

 * milestone:  Future Release => 4.9


Comment:

 @AdamWills Thanks for your patience, and sorry for the delay in reviewing
 this ticket.

 The /src/ patch looks good to me. I'm going to make a slight modification
 to the documentation, and add a `@since` annotation, before moving
 forward.

 Thanks so much for including tests. I'm going to modify them a bit:

 * Instead of comparing results of two comment queries to each other,
 compare the results of a query directly to a list of expected results.
 (Just in case the same bug affects both queries.)
 * Specify the comment dates and the query params more precisely, to be
 sure there are no problems with query/orderby indeterminacy in cases where
 the comments have matching comment_date_gmt.

 Thanks for the contribution!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38268#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform