[wp-trac] [WordPress Trac] #40538: Fix or remove useless PHPUnit tests

WordPress Trac noreply at wordpress.org
Thu Aug 17 22:19:37 UTC 2017


#40538: Fix or remove useless PHPUnit tests
------------------------------------------------+--------------------------
 Reporter:  johnbillion                         |       Owner:  johnbillion
     Type:  task (blessed)                      |      Status:  accepted
 Priority:  normal                              |   Milestone:  Future
Component:  Build/Test Tools                    |  Release
 Severity:  normal                              |     Version:
 Keywords:  needs-unit-tests ongoing has-patch  |  Resolution:
                                                |     Focuses:
------------------------------------------------+--------------------------
Changes (by Mte90):

 * keywords:  needs-unit-tests ongoing => needs-unit-tests ongoing has-patch


Comment:

 This patch remove the empty units for 4 tests :-)

 Are missing:

 {{{
 There were 4 risky tests:

 1) WP_Test_REST_Pages_Controller::test_prepare_item
 This test did not perform any assertions

 2) WP_Test_REST_Settings_Controller::test_context_param
 This test did not perform any assertions

 3) WP_Test_REST_Settings_Controller::test_prepare_item
 This test did not perform any assertions

 4) WP_Test_REST_Settings_Controller::test_get_item_schema
 This test did not perform any assertions
 }}}

 I am not sure about `prepare`, `context` and `get_item_schema` tests about
 what they have to do.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40538#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list