[wp-trac] [WordPress Trac] #41589: Add aria-current="page" to the admin menu current item

[WordPress Trac]

#41589: Add aria-current="page" to the admin menu current item
------------------------------------+----------------------------
 Reporter:  afercia                 |       Owner:  afercia
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.9
Component:  Administration          |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  aria-current has-patch  |     Focuses:  accessibility
------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  aria-current => aria-current has-patch
 * owner:   => afercia
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.9


Comment:

 [attachment:41589.diff] is a first pass and uses the already existing
 `$aria_attributes` variable to set the `aria-current` attribute. Tested
 also with some plugins that add their menu items and sub-items: of course,
 it works if plugins use the methods that core provides, it doesn't
 [https://github.com/Automattic/jetpack/blob/27f866db3c52b80373515818dea7ac306345b759/_inc/lib
 /admin-pages/class.jetpack-react-page.php#L50-L69 when plugins use custom
 methods]. In that case I'd say it's a plugin authors responsibility.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41589#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform