[wp-trac] [WordPress Trac] #40590: wp_video_shortcode always adds controls="controls"

[WordPress Trac]

#40590: wp_video_shortcode always adds controls="controls"
-----------------------------------+------------------------------
 Reporter:  paulschreiber          |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  General                |     Version:  4.7.4
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------------

Comment (by psiico):

 Yes, of course!

 @subrataemfluence I'm running the trunk version. Default theme and
 plugins. Edited the hello world post and pasted your code after the
 default content.
 {{{ [video src="https://www.youtube.com/watch?v=NhheiPTdZCw"
 controls="false"] }}}

 The hello world post renders as follows:

 [[Image(http://i.imgur.com/nLRpafj.png)]]

 The generated video html is as follows:
 {{{
 <div id="mep_0" class="mejs-container svg wp-video-shortcode mejs-video"
 tabindex="0" role="application" aria-label="Video Player" style="width:
 524px; height: 294px;"><div class="mejs-inner"><div class="mejs-
 mediaelement"><iframe class="me-plugin" id="me_youtube_0_container"
 frameborder="0" allowfullscreen="1" title="YouTube video player"
 width="524" height="294"
 src="https://www.youtube.com/embed/NhheiPTdZCw?controls=0&wmode=transparent&enablejsapi=1&origin=http%3A%2F%2Flocalhost&widgetid=1"
 style="width: 524px; height: 294px;"></iframe><video class="wp-video-
 shortcode" id="video-1-1" width="525" height="295" preload="metadata"
 style="width: 100%; height: 100%; display: none;"><source
 type="video/youtube"
 src="https://www.youtube.com/watch?v=NhheiPTdZCw&_=1"><a
 href="https://www.youtube.com/watch?v=NhheiPTdZCw">https://www.youtube.com/watch?v=NhheiPTdZCw</a></video></div><div
 class="mejs-layers"><div class="mejs-poster mejs-layer" style="display:
 none; width: 100%; height: 100%;"></div><div class="mejs-overlay mejs-
 layer" style="display: none; width: 100%; height: 100%;"><div class="mejs-
 overlay-loading"><span></span></div></div><div class="mejs-overlay mejs-
 layer" style="display: none; width: 100%; height: 100%;"><div class="mejs-
 overlay-error"></div></div><div class="mejs-overlay mejs-layer mejs-
 overlay-play" style="width: 100%; height: 100%;"><div class="mejs-overlay-
 button"></div></div></div><div class="mejs-controls" style="display:
 block;"><div class="mejs-button mejs-playpause-button mejs-play"><button
 type="button" aria-controls="mep_0" title="Play" aria-
 label="Play"></button></div><div class="mejs-time mejs-currenttime-
 container" role="timer" aria-live="off"><span class="mejs-
 currenttime">00:00</span></div><div class="mejs-time-rail" style="width:
 378px;"><span class="mejs-time-total mejs-time-slider" style="width:
 368px;" aria-label="Time Slider" aria-valuemin="0" aria-valuemax="322"
 aria-valuenow="0" aria-valuetext="00:00" role="slider" tabindex="0"><span
 class="mejs-time-buffering" style="display: none;"></span><span class
 ="mejs-time-loaded" style="width: 0px;"></span><span class="mejs-time-
 current" style="width: 0px;"></span><span class="mejs-time-handle"
 style="left: -5px;"></span><span class="mejs-time-float"><span class
 ="mejs-time-float-current">00:00</span><span class="mejs-time-float-
 corner"></span></span></span></div><div class="mejs-time mejs-duration-
 container"><span class="mejs-duration">05:22</span></div><div class="mejs-
 button mejs-volume-button mejs-mute"><button type="button" aria-
 controls="mep_0" title="Mute" aria-label="Mute"></button><a
 href="javascript:void(0);" class="mejs-volume-slider" style="display:
 none;"><span class="mejs-offscreen">Use Up/Down Arrow keys to increase or
 decrease volume.</span><div class="mejs-volume-total"></div><div class
 ="mejs-volume-current" style="height: 100px; top: 8px;"></div><div class
 ="mejs-volume-handle" style="top: 5px;"></div></a></div><div class="mejs-
 button mejs-fullscreen-button"><button type="button" aria-controls="mep_0"
 title="Fullscreen" aria-label="Fullscreen"></button></div></div><div class
 ="mejs-clear"></div></div></div>
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40590#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform