[wp-trac] [WordPress Trac] #35517: Work around PHP7 php-ssh2 breakage

[WordPress Trac]

#35517: Work around PHP7 php-ssh2 breakage
----------------------------+------------------------------
 Reporter:  dougal          |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Filesystem API  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  administration
----------------------------+------------------------------

Comment (by andythiel):

 I understand the reasoning that it is hard to fix and that the library
 needs to be fixed ...
 but usage is an argument that surprises me.

 I fear many people (those new to Wordpress who use Ubuntu 16.04 and are
 not hardcore Admins) fix this issue by granting permissions to www-data
 and setting FS_METHOD to "direct". At least that is the impression that I
 got from StackExchange like sites.

 For me the fixes in the diff above did not solve the issue.
 Deleting and Creating folders does not seem to work. Not sure where to
 look for exact error logging. It might be the same thing aberbenni
 mentioned or I messed up with copy&paste which the information below
 suggests.

 I too see no other way than giving up on ssh2 (but have a very bad feeling
 about it).
 Hope this gets resolved soon. +1 regarding priority from my side, for
 whatever that's worth.

 Some probably irrelevant information from the Wp FS Tester with the fixes
 above (probably should not contain any php code ... so yeah maybe I messed
 up copying the fixes but I double checked):

 {{{
 Files in folder

 Plugin location:        /var/www/firsttechfirst.com/wp-content/plugins/wp-
 filesystem-tester/wp-filesystem-tester.php (Local)
 /var/www/firsttechfirst.com/wp-content/plugins/wp-filesystem-tester/wp-
 filesystem-tester.php (FTP)
 Plugin Locations
 hello.php       /var/www/firsttechfirst.com/wp-content/plugins/ Delete
 file: /var/www/firsttechfirst.com/wp-content/plugins/hello.php
 akismet/akismet.php     /var/www/firsttechfirst.com/wp-
 content/plugins/akismet/ Delete entire folder: /var/www/firsttechfirst.com
 /wp-content/plugins/akismet/
 File IO Errors  Error: Could not create file /var/www/firsttechfirst.com
 /wp-content/plugins/super-long-name-not-to-conflict.php on server
 Downloading a zip       Downloading
 http://downloads.wordpress.org/plugin/akismet.zip... Suceeded
 Extracting Zip  Suceeded
 Zip Contents
 akismet/        0       ok      binary
 akismet/akismet.php     2409    ok      <?php
 /**
  * @package Akismet
  */
 /*
 Plugin Name: ...
 akismet/class.akismet-admin.php 43023   ok      <?php

 class Akismet_Admin {
         const NONCE = 'akism...
 akismet/class.akismet-cli.php   2712    ok      <?php

 WP_CLI::add_command( 'akismet', 'Akismet_CL...
 akismet/class.akismet.php       48848   ok      <?php

 class Akismet {
         const API_HOST = 'rest.aki...
 akismet/class.akismet-widget.php        2825    ok      <?php
 /**
  * @package Akismet
  */
 class Akismet_Wi...
 akismet/.htaccess       629     ok      binary
 akismet/_inc/   0       ok      binary
 akismet/_inc/akismet.css        11547   ok      binary
 akismet/_inc/akismet.js 6921    ok      binary
 akismet/_inc/form.js    700     ok      binary
 akismet/_inc/img/       0       ok      binary
 akismet/_inc/img/logo-full-2x.png       7570    ok      binary
 akismet/index.php       26      ok      <?php
 # Silence is golden....
 akismet/LICENSE.txt     18092   ok                          GNU GENERAL
 PUBLIC LICENSE
    ...
 akismet/readme.txt      15033   ok      === Akismet ===
 Contributors: matt, ryan, andy, md...
 akismet/views/  0       ok      binary
 akismet/views/config.php        10608   ok      <div id="akismet-plugin-
 container">
         <div class="a...
 akismet/views/get.php   608     ok      <form name="akismet_activate"
 action="https://akis...
 akismet/views/notice.php        9148    ok      <?php if ( $type ==
 'plugin' ) :?>
 <div class="upd...
 akismet/views/start.php 6757    ok      <div id="akismet-plugin-
 container">
         <div class="a...
 akismet/views/stats.php 744     ok      <div id="akismet-plugin-
 container">
         <div class="a...
 akismet/wrapper.php     6437    ok      <?php

 global $wpcom_api_key, $akismet_api_host, $...
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35517#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform