[wp-trac] [WordPress Trac] #38203: Remove `absint` on object IDs in `delete_metadata`, etc

WordPress Trac noreply at wordpress.org
Wed Apr 19 02:50:45 UTC 2017


#38203: Remove `absint` on object IDs in `delete_metadata`, etc
--------------------------------+------------------------------
 Reporter:  peterwilsoncc       |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Options, Meta APIs  |     Version:  2.9
 Severity:  normal              |  Resolution:
 Keywords:  2nd-opinion         |     Focuses:
--------------------------------+------------------------------

Comment (by peterwilsoncc):

 Replying to [comment:6 johnjamesjacoby]:

 Thanks so much for the research.

 I'd like to keep the ticket open as I still think `absint()` is invalid in
 this context, passing `$object_id = -4` shouldn't update object 4.
 `intval()` combined with checking for a positive number is a better but
 problematic in its own ways.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38203#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list