[wp-trac] [WordPress Trac] #37013: Minor Fixes: "Toggle indicator" in pages have focus color while the same in widgets/menus have none.

WordPress Trac noreply at wordpress.org
Tue Apr 18 15:47:51 UTC 2017


#37013: Minor Fixes: "Toggle indicator" in pages have focus color while the same in
widgets/menus have none.
-------------------------------------------------+-------------------------
 Reporter:  monikarao                            |       Owner:  afercia
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.8
Component:  Widgets                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  ui,
  testing                                        |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  good-first-bug has-patch has-screenshots needs-testing => has-
     patch has-screenshots needs-testing
 * owner:   => afercia
 * status:  new => assigned
 * milestone:  Future Release => 4.8


Comment:

 @westonruter there's a previous pending patch on #31476 that's ready for
 commit and the latest patch here is going to conflict with that.
 Apart from this, it's a bit hard to follow all the changes here. Changing
 color alone was an easy good first bug :) Changing element types, JS,
 a11y, CSS position and display, and many other details it's something that
 goes a bit beyond the original scope of the ticket. That's not to say it
 shouldn't be done, just to say it will require me a bit of time to check
 everything. Overall, looks like a nice improvement, thanks to everyone!
 One minor detail so far: buttons don't need a `keydown` event.

 I'd rather commit #31476 first and then review the changes here, if no
 objections.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37013#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list