[wp-trac] [WordPress Trac] #30439: Twenty Fourteen: Social Menu

WordPress Trac noreply at wordpress.org
Fri Sep 30 19:07:36 UTC 2016


#30439: Twenty Fourteen: Social Menu
--------------------------------------+-----------------------------
 Reporter:  wilflare                  |       Owner:
     Type:  feature request           |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  Bundled Theme             |     Version:  4.0.1
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------------

Comment (by toddmilliken):

 Replying to [comment:15 janhenckens]:
 > I've made this into 2 patches:
 > - 1 that adds the menu and the styling
 > - 1 that updates the genericons in twentyfourteen
 >
 > Testing & feedback are welcome :)

 When testing the patch for twenty-fourteen, the social menu looked good
 but I noticed a side-effect on each post's meta information (date,
 comments, and edit link). The font icons were unable to render due to CSS
 Parse issue - there was one extra trailing slash at line 3334 in the
 theme's stylesheet style.css. Removing the comma fixed the parse error,
 the patch looks ok now.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30439#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list