[wp-trac] [WordPress Trac] #37297: Deprecate get_blogaddress_by_id function

[WordPress Trac]

#37297: Deprecate get_blogaddress_by_id function
--------------------------------+------------------------
 Reporter:  spacedmonkey        |       Owner:
     Type:  enhancement         |      Status:  reviewing
 Priority:  normal              |   Milestone:  4.7
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  needs-patch         |     Focuses:  multisite
--------------------------------+------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch => needs-patch
 * owner:  jeremyfelt =>


Comment:

 I spent some time with [attachment:37297.diff] the other day and ran into
 some uncertainty.

 As @thomaswm mentioned, `get_home_url()` is not appropriate solution for
 `install_blog()`. `get_blogaddress_by_id()` attempts to use the home
 option to determine the URL's scheme, but it will always be empty at this
 point. We then know it will be HTTP combined with the site's domain and
 path.

 It does seem to be the right option for `wpmu_welcome_notification()`. I'd
 like this to be tested more though.

 The use in `wp-activate.php` has already been removed via #26855.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37297#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform