[wp-trac] [WordPress Trac] #37819: _load_textdomain_just_in_time() is really not nice with alternative translations

WordPress Trac noreply at wordpress.org
Thu Sep 22 12:06:34 UTC 2016


#37819: _load_textdomain_just_in_time() is really not nice with alternative
translations
--------------------------------------+------------------------------
 Reporter:  imath                     |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  I18N                      |     Version:  4.6
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by imath):

 37819.2.diff contains an alternative and simplier fix: it's using
 `$mo->merge_originals_with()` for any cases and is removing the reference
 operator in `$l10n[$domain] = &$mo;`

 The patch also contains 2 more tests to check multiple/incomplete mofiles.
 The mofiles.2.tar contains the `.mo` files i've used.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37819#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list