[wp-trac] [WordPress Trac] #32360: Add oEmbed provider unit tests

WordPress Trac noreply at wordpress.org
Fri Sep 9 19:54:03 UTC 2016


#32360: Add oEmbed provider unit tests
-------------------------+--------------------------
 Reporter:  johnbillion  |       Owner:  johnbillion
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.7
Component:  Embeds       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |     Focuses:
-------------------------+--------------------------

Comment (by boonebgorges):

 > I guess it makes sense for the tests to remain in a group which never
 gets tested by default (ie. without passing the --group external-oembed
 flag), but then I'm not sure if that's super valuable.

 I just ran into this, because the `<exclude><group>external-
 oembed</group></exclude>` added to phpunit.xml.dist wasn't automatically
 picked up by my custom phpunit.xml.

 I definitely think it's wise to have tests for this stuff, and I think
 it's smart for them not to run by default. But if they're failing on a
 regular and predictable basis, then they shouldn't be in core (or perhaps
 they should be commented out in the dataProvider while the details are
 ironed out).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32360#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list