[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

WordPress Trac noreply at wordpress.org
Wed Sep 7 20:35:53 UTC 2016


#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:  pento
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.7
Component:  Plugins                              |     Version:  2.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by aaroncampbell):

 [attachment:17817.24.diff] adds the `@return` for the methods that
 @ocean90 pointed out were missing it. It also removes the `return` from
 the `rewind()` method since [http://php.net/manual/en/iterator.rewind.php
 it's ignored anyway]. All tests still appear to pass, and I pounded on the
 iterator a decent bit and the rewinding seems to still work as expected.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:211>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list