[wp-trac] [WordPress Trac] #25293: Switch_to_blog not switching the siteid

[WordPress Trac]

#25293: Switch_to_blog not switching the siteid
------------------------------------------------+--------------------------
 Reporter:  Rahe                                |       Owner:
     Type:  defect (bug)                        |      Status:  new
 Priority:  normal                              |   Milestone:  Future
Component:  Networks and Sites                  |  Release
 Severity:  minor                               |     Version:  3.0
 Keywords:  has-patch dev-feedback 2nd-opinion  |  Resolution:
                                                |     Focuses:  multisite
------------------------------------------------+--------------------------

Comment (by tfrommen):

 Replying to [comment:13 flixos90]:
 > Replying to [comment:12 tfrommen]:
 > > Personally, I don't like the patch because it introduces a class that
 does too many (related, and yet clearly distinct) things.
 >
 > I'm not exactly sure why the breakpoint functionality shouldn't be
 handled by this class, could you clarify a bit? However if this is a
 problem, we can leave the two methods out first and then think about the
 patch as possible solution for this very ticket.

 What you described as a ''breakpoint'' is exactly what is handled by an
 '''instance''' of a `NetworkState` like I proposed, no? So breakpoints are
 a meta layer for network states - which is why breakpoints shouldn't be
 handled by the network state class. The latter just has to provide/be an
 immutable snapshot with the ability to ''apply'' it (i.e., restore).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25293#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform