[wp-trac] [WordPress Trac] #17817: do_action/apply_filters/etc. recursion on same filter kills underlying call

[WordPress Trac]

#17817: do_action/apply_filters/etc. recursion on same filter kills underlying call
-------------------------------------------------+-------------------------
 Reporter:  kernfel                              |       Owner:  pento
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.7
Component:  Plugins                              |     Version:  2.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by ocean90):

 Thanks @pento.

 I run the tests with [attachment:17817.22.diff] on PHP 7.1 RC1 and it
 seems like it also fixes #37295 and #37772.

 But there is one failure when running `phpunit -c
 tests/phpunit/multisite.xml`:

 {{{
 1) Test_Nav_Menus::test_wp_get_associated_nav_menu_items
 Trying to get property of non-object

 /src/wp-includes/ms-blogs.php:1221
 /src/wp-includes/class-wp-hook.php:294
 /src/wp-includes/class-wp-hook.php:319
 /src/wp-includes/plugin.php:453
 /src/wp-includes/post.php:2414
 /tests/phpunit/tests/post/nav-menu.php:101
 }}}

 I created a PR on @jorbin's GitHub mirror to run the tests on Travis CI:
 https://github.com/aaronjorbin/develop.wordpress/pull/16 / https://travis-
 ci.org/aaronjorbin/develop.wordpress/builds/157840503

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17817#comment:207>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform