[wp-trac] [WordPress Trac] #35501: Dashboard page: incorrect work of "Activity" group box bottom counters

WordPress Trac noreply at wordpress.org
Thu Sep 1 15:32:30 UTC 2016


#35501: Dashboard page: incorrect work of "Activity" group box bottom counters
-------------------------------------+-------------------------------------
 Reporter:  antonrinas               |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  Comments                 |     Version:  4.4.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch early          |     Focuses:  javascript,
  4.7-early                          |  administration
-------------------------------------+-------------------------------------

Comment (by adamsilverstein):

 @vagios Thanks for your latest patch.

 I tested the patch and verified it works as expected.

 I like the way you track the xhrs by element and isolate the blocking that
 way. This neatly resolves the issue presented by slower connections.

 I wonder if we should consider a similar approach on #25696 where slower
 connections would similarly block the simultaneous editing of multiple
 rows @azaozz pointed out here.

 [attachment:35501.6.patch] is a refreshed patch with a few small changes:
  * For undefined checks I switched to ` 'undefined' !== typeof var `  (
 because ` undefined !== var` throws an error if var is undefined)
  * Added some whitespace inside square brackets
 ([https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/javascript/ wp js coding standards])

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35501#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list