[wp-trac] [WordPress Trac] #38391: Twenty Seventeen: Background colour for header

[WordPress Trac]

#38391: Twenty Seventeen: Background colour for header
----------------------------------------+------------------
 Reporter:  laurelfulford               |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  4.7
Component:  Bundled Theme               |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:
----------------------------------------+------------------
Changes (by celloexpressions):

 * keywords:  needs-patch => needs-patch good-first-bug


Comment:

 I missed this in #38426 - we need to make an active callback for the
 header text color control that returns `has_header_image() ||
 has_header_video()`. I don't think we need to make any frontend changes
 here, only change when the option is visible to be based on when it
 actually applies.

 Adding the active callback above (via `$wp_customize->get_control()`)
 would be a good first bug if any new contributors are able to give that a
 try.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38391#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform