[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-------------------------------------+-------------------------------------
 Reporter:  davidakennedy            |       Owner:  joemcgill
     Type:  task (blessed)           |      Status:  accepted
 Priority:  normal                   |   Milestone:  4.7
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  ux-feedback dev-feedback has-      |  javascript
  screenshots                        |
-------------------------------------+-------------------------------------

Comment (by celloexpressions):

 [attachment:38172.10.diff]:
 - Fix Twenty Seventeen when no image is set.
 - Remove the validation for there not being a local video when an external
 video is set.
 - Only play video on screens wider than 900px and taller than 500px (I
 made these numbers up, they can be changed to whatever).
 - Only show video if `is_front_page`, otherwise show the image. We should
 consider making the customizer controls contextual to this behavior.
 - I'm still not seeing local videos loop in Chrome/Windows, but the video
 tag hass the loop attribute. Not sure why.

 @joemcgill please review and @bradyvercher if you have time to take
 another stab at this before an initial commit tonight, please do. We also
 need to add a few things later but any bugs would be good to fix before
 beta. Testing with Twenty Seventeen and Twenty Fourteen it works pretty
 well now with YouTube or self hosted videos.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:61>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform