[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-------------------------------------+-------------------------------------
 Reporter:  davidakennedy            |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  4.7
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  ux-feedback dev-feedback has-      |  javascript
  screenshots                        |
-------------------------------------+-------------------------------------

Comment (by joemcgill):

 Been playing with this feature over the past few days and wanted to add my
 thoughts. Generally, I think you all have done a nice job of working
 through the implementation issues here. A few issues I noticed while
 testing [attachment:38172.9.diff the latest patch], some of which are
 theme specific.

 * My main concern about making this a core feature is that we're
 encouraging sites to push more bandwidth at users. Setting a size limit on
 videos to 8MB is helpful, but I think it's wasteful to load the header
 image only to immediately swap it for the video HTML once the document
 loads. I would rather see us lazy load either the video or the image,
 depending on context and browser support, not both.
 * Related, it looks like this loads both the header image and video
 regardless of screen size. I know that trying to assume much about
 someone's connection based on screen size can be problematic, but I'm
 curious if there is a way to set a minimum width for loading the video.
 * In TwentySeventeen, video headers seem to only work if you also have an
 image header set. This does not a requirement in TwentyFourteen. Not sure
 which is the intended functionality, but either way, the UX could be more
 clear here. If video headers ''are'' dependent on setting an image, I
 would suggest moving those controls beneath the image controls in the
 customizer.
 * When switching from a local video header to an external video, I had to
 first remove the local video and save my settings before setting the
 external URL, otherwise the validation callback still sees the ID for the
 local video and returns an error.
 * In my testing, YouTube URLs don't automatically loop, so you see the YT
 play button once the video ends, which is kind of odd. Additionally,
 YouTube videos don't autoplay on mobile devices and click events don't
 seem to reach the iframe in order to start them (in TwentySeventeen at
 least).

 Overall, I think these problems can be worked out, though I will note that
 I still have reservations about making this a core feature because of
 concerns about performance and developer experience. Seems like this
 feature still puts a lot of responsibility on theme authors to work out
 implementation details—for example, TwentySeventeen only displays header
 videos on the home page, while the latest patch for TwentyFourteen
 displays these on all pages. I would not like to see us encourage bad
 video header implementations in themes by rushing this out the door.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform