[wp-trac] [WordPress Trac] #38488: Twenty Seventeen: Replace remaining Genericons with Font Awesome icons

WordPress Trac noreply at wordpress.org
Wed Oct 26 18:08:05 UTC 2016


#38488: Twenty Seventeen: Replace remaining Genericons with Font Awesome icons
---------------------------+------------------
 Reporter:  melchoyce      |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+------------------

Comment (by melchoyce):

 Replying to [comment:6 sami.keijonen]:
 > Not sure if I did this right but there is a patch file for test.

 Your patch is good, thanks. :)

 > I used `arrow-left` and `arrow-right`. They seem a little thick so we
 might need to try long arrows or carets.

 I agree. Might also need to adjust the size of the icons, based on how
 they look. Would you mind trying out long arrows and carets and add some
 screenshots before uploading a patch?

 The angles might also need some slight tweaking to vertically align them
 with the text — right now the down angle on menus should probably be `top:
 -1px;` instead of `-2px`.

 Thumbtack looks perfect :)

 Thanks for continuing to work on this!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38488#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list