[wp-trac] [WordPress Trac] #38172: Enable Video Headers in Custom Headers

[WordPress Trac]

#38172: Enable Video Headers in Custom Headers
-------------------------------------+-------------------------------------
 Reporter:  davidakennedy            |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  normal                   |   Milestone:  4.7
Component:  Themes                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ui-feedback    |     Focuses:  ui, accessibility,
  ux-feedback dev-feedback has-      |  javascript
  screenshots                        |
-------------------------------------+-------------------------------------

Comment (by davidakennedy):

 I tested the latest patch, [attachment:38172.8.diff], from
 @celloexpressions.

 Nice work! It's a solid effort at combining the two approaches, uploaded
 video and external video via a URL. I did find some issues, some of which
 are mentioned already.

 I made a video showing some of these issues, since that may be easier for
 debugging. See: https://cloudup.com/cqnz7llIIGF

 * If a file is too big for upload, it still looks like it's uploaded in
 the Customizer and the Save & Publish button changes state.
 * Putting a external video URL in when an uploaded video is already
 present is a bit buggy. The preview doesn't update like it should.

 Front end issues:

 * There is no visual play/pause button. This is a requirement for basic
 accessibility, and it should be reachable and operable via the keyboard.
 Play/pausing does occur if I click the entire video, but that isn't
 obvious.
 * Looping seemed not to work, even though the `loop` parameter is on the
 video tag.

 Theme API:

 * It would be nice to have some classes to the `#wp-custom-header` and
 `#wp-custom-header-video` containers.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38172#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform