[wp-trac] [WordPress Trac] #22058: Improve custom background properties UI

[WordPress Trac]

#22058: Improve custom background properties UI
-------------------------------------+-------------------------------------
 Reporter:  grapplerulrich           |       Owner:  westonruter
     Type:  enhancement              |      Status:  reviewing
 Priority:  normal                   |   Milestone:  4.7
Component:  Customize                |     Version:  3.4.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots commit                 |  administration
-------------------------------------+-------------------------------------

Comment (by cdog):

 @afercia `ui-helper-hidden-accessible` is an alias of `screen-reader-
 text`. See: [https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/common.css?rev=37714#L121 wp-admin/css/common.css]. We can
 switch with the later if it's causing any trouble (it should have the same
 effeect). I haven't used the `display` or `visibility` properties to hide
 the radios, as hidden inputs don't receive focus (i.e. pressing tab skips
 them).

 Also forgot to comment some CSS lines. In `wp-admin/css/themes.css` I've
 added:

 {{{
 .background-position-control .button-group .button {
         -webkit-border-radius: 0;
         border-radius: 0;
         -webkit-box-shadow: none;
         box-shadow: none;
         height: 40px !important;
         line-height: 37px !important;
         margin: 0 -1px 0 0 !important;
         padding: 0 10px 1px !important;
         position: relative;
 }
 }}}

 The properties with `!important` get overridden by core responsive styles
 (see: [https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/css/buttons.css wp-includes/css/buttons.css]).

 Thakns again everyone for getting involved!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22058#comment:103>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform