[wp-trac] [WordPress Trac] #38383: Twenty Seventeen: Incorrect use of `_x()` in `twentyseventeen_posted_on()`

[WordPress Trac]

#38383: Twenty Seventeen: Incorrect use of `_x()` in `twentyseventeen_posted_on()`
----------------------------------------+------------------
 Reporter:  ocean90                     |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  4.7
Component:  Bundled Theme               |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:
----------------------------------------+------------------
Changes (by ocean90):

 * keywords:  good-first-bug has-patch needs-testing => good-first-bug
     needs-patch


Comment:

 Thanks for your patch, @dineshc.

 The "by %s" string needs a translators comment which explains the
 placeholder.

 The other string should be improved so that the span tag is available for
 translators: `__( '<span class="screen-reader-text">Posted on </span>%s',
 'twentyseventeen' )`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38383#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform