[wp-trac] [WordPress Trac] #34391: Harden panel/section UI code by removing contents from being logically nested (read: goodbye margin-top hacks)

[WordPress Trac]

#34391: Harden panel/section UI code by removing contents from being logically
nested (read: goodbye margin-top hacks)
-----------------------------+--------------------------------------------
 Reporter:  westonruter      |       Owner:  delawski
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  4.7
Component:  Customize        |     Version:  4.0
 Severity:  normal           |  Resolution:  fixed
 Keywords:  early has-patch  |     Focuses:  ui, accessibility, javascript
-----------------------------+--------------------------------------------
Changes (by celloexpressions):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Looks like when the UI for #37661 was reworked, it no longer required un-
 detaching the panel there. But the patch still moved
 `panel.renderContent()` out of the conditional, which I believe was the
 required fix here.
 {{{
 customize-controls.js:
 1324    1591           if ( ! panel.contentContainer.parent().is(
 panel.headContainer ) ) {
 1325    1592                container.append( panel.contentContainer );
 1326            -           panel.renderContent();
 1327    1593          }
         1594    +     panel.renderContent();
 }}}

 Closing as fixed for now; please report any additional issues in new
 tickets.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34391#comment:64>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform