[wp-trac] [WordPress Trac] #38348: Replace get_blog_details() usage in wp-admin/my-sites.php with get_site()

WordPress Trac noreply at wordpress.org
Wed Oct 19 05:58:01 UTC 2016


#38348: Replace get_blog_details() usage in wp-admin/my-sites.php with get_site()
--------------------------------+-------------------------
 Reporter:  flixos90            |       Owner:  jeremyfelt
     Type:  enhancement         |      Status:  reviewing
 Priority:  normal              |   Milestone:  4.7
Component:  Networks and Sites  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+-------------------------
Changes (by jeremyfelt):

 * owner:   => jeremyfelt
 * status:  new => reviewing
 * milestone:  Awaiting Review => 4.7


Comment:

 `$site_id` is added as a global in `ms-settings.php` (unfortunately), so
 I'm a little wary of reassigning it here just for the purpose of calling
 `get_site()` just in case someone is relying it.

 Let's stick to the existing format and pass `(int)
 $_POST['primary_blog'];` directly to `get_site()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38348#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list