[wp-trac] [WordPress Trac] #36984: Customizer Menus: Show Pages at the top of the list, expanded

WordPress Trac noreply at wordpress.org
Sun Oct 16 23:26:40 UTC 2016


#36984: Customizer Menus: Show Pages at the top of the list, expanded
-----------------------------------------+---------------------------------
 Reporter:  melchoyce                    |       Owner:  ryankienstra
     Type:  enhancement                  |      Status:  reopened
 Priority:  normal                       |   Milestone:  4.7
Component:  Customize                    |     Version:  4.3
 Severity:  normal                       |  Resolution:
 Keywords:  needs-patch has-screenshots  |     Focuses:  ui, administration
-----------------------------------------+---------------------------------

Comment (by ryankienstra):

 '''Pull Request And Identical Patch To Address Bug'''

 Hi @westonruter and @celloexpressions,
 This [https://github.com/xwp/wordpress-develop/pull/172 GitHub pull
 request] and
 [https://core.trac.wordpress.org/attachment/ticket/36984/172.diff
 identical patch] address the bug that @celloexpressions
 [https://core.trac.wordpress.org/ticket/36984#trac-
 change-14-1476560594816819 found].


 In adding new menu items, sometimes the 'Pages' section collapsed
 * If you [https://core.trac.wordpress.org/attachment/ticket/36984/pages-
 collapsed.png opened the "Pages" section] before it was loaded
 * When dynamically loading more pages on scrolling

 This is because the logic triggered `.click()`, even when it was open.

 As @celloexpressions [https://core.trac.wordpress.org/ticket/36984#trac-
 change-19-1476645296601999 suggested], this commit [https://github.com/xwp
 /wordpress-develop/pull/172/files#diff-
 027b34627f17d21422fd5065315a6226R400 checks if the section] `hasClass(
 'open' )`. And only triggers a click if it doesn't have that class.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36984#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list